Update rgb-lcd.py #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added comment for changing the bus if using Edison.
|
Thanks for the PR. However we know switch to def_i2c_bus in libmraa if the i2c bus is invalid so such things are no longer required (since 0.5.2 release). The i2c bus number (if people really care) is explained in the edison specific libmraa doc. For future commits please prefix your commits with file/area you have modified, in this case 'rgb-lcd.py: ' and add a sign-off-by line (git commit --amend -s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added comment for changing the bus if using Edison.