Replace images and icons with new logoUpdate #3
Conversation
There was a problem hiding this comment.
Thank you very much Simon! I tested it on Ubuntu and it seems to work fine!
Now that I saw it in the application I was wondering though, whether the CDT Cloud Blueprint logo wouldn't look better if instead of white we'd use a color for the font and the cloud, e.g. blue, and made the background transparent. Then it'll probably look better in any theme.
What do you think?
Note that I did something similar here for the website, but kept the foreground color white as it'll be there on a dark background: https://github.com/eclipse-cdt-cloud/website/pull/39/files#diff-28cc6c24e0b1c72feb2ff61a0626a099b24e41c6d150b1f1162dc970131c0577
|
Sure i can work on this tommorrow. Do you have any objections about the blue used in the Theia blueprint logo? |
|
Thanks, sounds great! |
As part of a merge of upstream electron-builder's native rebuilding was turned off. Upstream now uses Theia's Electron native rebuilding which was missed in CDT Cloud Blueprint and therefore lead to broken packaged builds. This is now fixed. Fixes eclipse-cdt-cloud#60 Contributed on behalf of STMicroelectronics
|
@sgraband Please see also eclipse-cdt-cloud/cdt-cloud#34. Thank you! |
Contributed on behalf of STMicroelectronics
Changed the files and also adjusted the preload.html. Contributed on behalf of STMicroelectronics
Contributed on behalf of STMicroelectronics
|
Made everything transparent and used the new improved version from the other PR. |
|
@sgraband Can you please open a PR against https://github.com/eclipse-cdt-cloud/cdt-cloud-blueprint? Thank you! |
|
Done: eclipse-cdt-cloud#64 |
|
Merged in eclipse-cdt-cloud#64 |
What it does
Changed the files and also adjusted the preload.html.
Contributed on behalf of STMicroelectronics
How to test