-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add code response part renderer #107
Add code response part renderer #107
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Code renderer is really nice!
Boundary detection should be improved to properly wrap the code segments, but this could be done in a follow-up.
Do we even need the mock responses at all? It's pretty straightforward to get the AI Agent to return a code block in any desired language
packages/ai-chat-ui/src/browser/chat-response-renderer/code-part-renderer.tsx
Outdated
Show resolved
Hide resolved
packages/ai-chat-ui/src/browser/chat-response-renderer/code-part-renderer.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…week24/19-code-response-part-renderer
…response-part-renderer ; Conflicts: ; packages/ai-chat/src/browser/agent-frontend-module.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works! thanks!
What it does
Close https://github.com/eclipsesource/osweek-2024/issues/19
Part of https://github.com/eclipsesource/osweek-2024/issues/54
Adds a renderer for a code block using the monaco editor.
Implements:
The parser needs improvement.
How to test
Follow-ups
Review checklist
Reminder for reviewers