Use binary message RPC protocol for plugin API #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tortmayr
force-pushed
the
plugin-rpc-v2
branch
2 times, most recently
from
6eb943b
to
037f099
Compare
tortmayr
force-pushed
the
plugin-rpc-v2
branch
4 times, most recently
from
b2be158
to
d58af42
Compare
lucas-koehler
approved these changes
Jun 3, 2022
tortmayr
force-pushed
the
plugin-rpc-v2
branch
5 times, most recently
from
0d32810
to
d1fe95b
Compare
The commit fixes `unstage all` to properly reset the index rather than report errors or discard changes. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
* docs: update changelog for `v1.31.1` The commit updates the `changelog` for the `v1.31.0` release to highlight notable new features, fixes, and any potential breaking changes. The change also includes misc typo fixes. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
The commit adds an entry for the `unstage all` fix in the `1.31.0` changelog. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
The commit upgrades `socket.io` to fix a known critical vulnerability with `socket.io-parser`. CVE: https://security.snyk.io/vuln/SNYK-JS-SOCKETIOPARSER-3091012 Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
The commit includes the following changes: - upgrades `lerna` - upgrades `mocha` including our config files - upgrades `minimatch` The main reason of the upgrade was to fix known vulnerabilties and benefit from the newer mocha version. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
The commit adds a note regarding the `socket.io-parser` resolution in our migration guide for downstream adopters. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
tortmayr
force-pushed
the
plugin-rpc-v2
branch
3 times, most recently
from
768950c
to
2b4016e
Compare
Refactors the plugin RPC protocol to make use of the new message-rpc introduced with eclipse-theia#11011/eclipse-theia#11228. - Refactor plugin-ext RpcProtocol API to reuse the new message-rpc protocol - Remove custom RPC message encoding and handling reuse message-rpc - Implement `BatchingChannel` that queues messages and sends them accumulated on the next process.tick (replaces the old Multiplexer implementation) - Refactors proxy handlers and remote target handlers - Use `Channel` instead of `MessageConnection` for creating new instances of RPCProtocol - Refactor `RpcMessageEncoder`/`RpcMessageDecoder` to enable overwritting of already registered value encoders/decoders. - Add mode property to base `RpcProtocol` to enable switching from a bidirectional RPC protocol to a client-only or server-only variant. - Implement special message encoders and decoders for the plugin communication. (Replacement for the old `ObjectTransferrer` JSON replacers/revivers) - Adapt `HostedPluginServer` and `HostedPluginClient` API to send/receive messages in binary format instead of strings. This enables direct writethrough of the binary messages received from the hosted plugin process. - Adapt `hosted-plugin-process` and `plugin-host` to directly send binary messages via `IpcChannel`/`BinaryMessagePipe` - Remove incorrect (and unused) notification proxy identifiers and instantiation - NotificationExt was instantiated in the main context - There were unused notification proxy identifiers for main and ext in the wrong contexts Part of eclipse-theia#10684 Fixes eclipse-theia#9514 Contributed on behalf of STMicroelectronics
tortmayr
force-pushed
the
plugin-rpc-v2
branch
from
2b4016e
to
d5d67db
Compare
|
Merged upstream with eclipse-theia#11261 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Refactors the plugin RPC protocol to make use of the new message-rpc introduced with eclipse-theia#11011/eclipse-theia#11228.
Refactor plugin-ext RpcProtocol API to reuse the new message-rpc protocol
QueuingChannelMultiplexerthat queues messages and sends them accumulated on the next process.tick (replaces the old Multiplexerimplementation)
Channelinstead ofMessageConnectionfor creating new instances of RPCProtocolRpcMessageEncoder/RpcMessageDecoderto enable overwritting of already registered value encoders/decoders.RpcProtocolto enable switching from a bidirectional RPC protocol to a client-only or server-only variant.Implement special message encoders and decoders for the plugin communication. (Replacement for the old
ObjectTransferrerJSON replacers/revivers)Adapt
HostedPluginServerandHostedPluginClientAPI to send/receive messages in binary format instead of strings. This enables direct writethrough of the binary messages received from the hosted plugin process.Adapt
hosted-plugin-processandplugin-hostto directly send binary messages viaIpcChannel/BinaryMessagePipeRemove incorrect (and unused) notification proxy identifiers and instantiation
Part of eclipse-theia#10684
Fixes eclipse-theia#9514
Co-authored-by: Lucas Koehler lkoehler@eclipsesource.com
Contributed on behalf of STMicroelectronics
How to test
Review checklist
Reminder for reviewers