I18n for EN & FR languages #23
Conversation
| "update": "Update failed" | ||
| }, | ||
| "share": { | ||
| "text": "Click To See Your Github Data Analysis", | ||
| "mobileText": "See Your Github Data Analysis", | ||
| "toggleOpen": "Share opened", | ||
| "toggleClose": "Share closed" | ||
| "toggleOpen": "Share enabled", |
There was a problem hiding this comment.
I'm not quite sure about this.
| }, | ||
| "loginPage": { | ||
| "title": "hacknical | make a better resume", | ||
| "title": "Hacknical | Make a better resume", |
There was a problem hiding this comment.
Hacknical should always be in Capital (brand/product name)
| @@ -33,18 +33,18 @@ | |||
| "messages": { | |||
| "error": { | |||
| "findUser": "Find user failed", | |||
| "frequent": "Too frequent, please try %s minutes later", | |||
| "frequent": "Too many attempts, please try in %s minutes", | |||
| "update": "Update failed" | |||
| }, | |||
| "share": { | |||
| "text": "Click To See Your Github Data Analysis", | |||
There was a problem hiding this comment.
It is not really common to have an uppercase letter at each word, I let it that way because it looks like you did it on purpose, but I wouldn't really recommend it.
There was a problem hiding this comment.
You are right. I'll merge this request first and check all of theme.
| "404": "404 not found.", | ||
| "text": "WTF? YOU ARE IN THE NO-MANS LAND", | ||
| "redirectText": "s later go back to home" | ||
| "redirectText": "Going back home in a few seconds" |
There was a problem hiding this comment.
Not quire sure about this, but the later was wrong. ;)
There was a problem hiding this comment.
I do this beacuse this page has a countdown like this:
But never mind. I think I can change redirectText to "Going back home in %s seconds"
I'm starting with a few improvements to the EN version to make sure the main translation is fine. Once done I'll had the FR version. I can make another PR if you wish to merge this one first. :)