-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import PX4Log files #8
Comments
@ecmnet Any chance that you will be able to implement this soon? :) It would be great to have the ability to replay px4log files :) Thanks! |
@mhkabir This is quite a difficult question. Currently MAVGCL uses a flat data model structure (with hardcoded key figures), which I took over from my previous flight stack implementation. Now, I am not sure whether to keep that model as a dynamic one would give more flexibility. Since this question is tightly coupled to the mavlink-parser, I use, I thought about waiting for MAVLINK 2.0, before changing that. On the other hand, it would be quite easy to keep the current model and assign the key-figures of the px4log to that flat model. So, to be honest, I just don't know what to do here. What is your opinion? |
@ecmnet Mavlink 2.0 is still sometime away. I think it would be prudent to keep using the current model (hey, it works well!) till we can get a stable MAVLink 2.0 spec. |
@mhkabir Basic PX4Log Import implemented. Currently I have mapped only L.NEDX,Y,Z. Further mapping to do in https://github.com/ecmnet/MAVComm/blob/master/MAVComm/src/com/comino/msp/model/MSTYPE.java |
@ecmnet Awesome :) How can I test? What's the best way to help you add more support? |
@mhkabir just run the app in any mode, open px4file and select LocalPosition. The screenshot shows an uploaded px4log: Note: I am connected to my vehicle. Therefore the details are updated. Those do NOT relate to the uploaded data currently. Working on this. |
Note: As the sampling in MAVGCL is currently fixed to 50ms, px4logs will be read accordingly and thus provide NOT the full resolution in time |
@mhkabir Is there any easy readable list of the px4log abbreviations available ? This would make mapping more easy for me. |
@mhkabir Yes. Thanks a lot! |
Thanks for this. I pulled master, and built it, but I can't find a way to This must be something silly on my part, but what do I press to be able to
|
@mhkabir Hm. Should be under the menu File -> Import px4Log |
@mhkabir Btw. Let me know, which additional key-figures (either from MAVLink or from px4Log) would be useful for you... |
@mhkabir SystemMenu issue fixed. |
No description provided.
The text was updated successfully, but these errors were encountered: