Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import PX4Log files #8

Closed
ecmnet opened this issue Feb 12, 2016 · 16 comments
Closed

Import PX4Log files #8

ecmnet opened this issue Feb 12, 2016 · 16 comments

Comments

@ecmnet
Copy link
Owner

ecmnet commented Feb 12, 2016

No description provided.

@mhkabir
Copy link

mhkabir commented Mar 17, 2016

@ecmnet Any chance that you will be able to implement this soon? :) It would be great to have the ability to replay px4log files :)

Thanks!

@ecmnet
Copy link
Owner Author

ecmnet commented Mar 17, 2016

@mhkabir This is quite a difficult question. Currently MAVGCL uses a flat data model structure (with hardcoded key figures), which I took over from my previous flight stack implementation. Now, I am not sure whether to keep that model as a dynamic one would give more flexibility. Since this question is tightly coupled to the mavlink-parser, I use, I thought about waiting for MAVLINK 2.0, before changing that. On the other hand, it would be quite easy to keep the current model and assign the key-figures of the px4log to that flat model. So, to be honest, I just don't know what to do here. What is your opinion?

@mhkabir
Copy link

mhkabir commented Mar 17, 2016

@ecmnet Mavlink 2.0 is still sometime away. I think it would be prudent to keep using the current model (hey, it works well!) till we can get a stable MAVLink 2.0 spec.
There is practically nothing we can use to replay logs currently, and MAVGCL is the best option for this to date. If we can get log-replay working, it would also increase the user base for this application.

@ecmnet
Copy link
Owner Author

ecmnet commented Mar 17, 2016

@mhkabir Basic PX4Log Import implemented. Currently I have mapped only L.NEDX,Y,Z. Further mapping to do in https://github.com/ecmnet/MAVComm/blob/master/MAVComm/src/com/comino/msp/model/MSTYPE.java

@mhkabir
Copy link

mhkabir commented Mar 17, 2016

@ecmnet Awesome :) How can I test? What's the best way to help you add more support?

@ecmnet
Copy link
Owner Author

ecmnet commented Mar 17, 2016

@mhkabir just run the app in any mode, open px4file and select LocalPosition. The screenshot shows an uploaded px4log:

screenshot

Note: I am connected to my vehicle. Therefore the details are updated. Those do NOT relate to the uploaded data currently. Working on this.

@ecmnet
Copy link
Owner Author

ecmnet commented Mar 17, 2016

Note: As the sampling in MAVGCL is currently fixed to 50ms, px4logs will be read accordingly and thus provide NOT the full resolution in time

@ecmnet
Copy link
Owner Author

ecmnet commented Mar 17, 2016

@mhkabir Is there any easy readable list of the px4log abbreviations available ? This would make mapping more easy for me.

@mhkabir
Copy link

mhkabir commented Mar 17, 2016

@mhkabir
Copy link

mhkabir commented Mar 17, 2016

@ecmnet
Copy link
Owner Author

ecmnet commented Mar 17, 2016

@mhkabir Yes. Thanks a lot!

@ecmnet ecmnet closed this as completed Mar 18, 2016
@mhkabir
Copy link

mhkabir commented Mar 18, 2016

Thanks for this. I pulled master, and built it, but I can't find a way to
import a file...

This must be something silly on my part, but what do I press to be able to
load the log?
On 18 Mar 2016 6:20 pm, "Eike" notifications@github.com wrote:

Closed #8 #8.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#8 (comment)

@ecmnet ecmnet reopened this Mar 18, 2016
@ecmnet
Copy link
Owner Author

ecmnet commented Mar 18, 2016

@mhkabir Hm. Should be under the menu File -> Import px4Log

@ecmnet
Copy link
Owner Author

ecmnet commented Mar 18, 2016

It's a bit weird. JavaFX does not use the OS X Menu-Line:

import

I just looked around and there seems to be a fix for this.

@ecmnet
Copy link
Owner Author

ecmnet commented Mar 18, 2016

@mhkabir Btw. Let me know, which additional key-figures (either from MAVLink or from px4Log) would be useful for you...

@ecmnet
Copy link
Owner Author

ecmnet commented Mar 20, 2016

@mhkabir SystemMenu issue fixed.

@ecmnet ecmnet closed this as completed Mar 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants