Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix undefined variable and clean up LEDIR #1

Closed
wants to merge 15 commits into from
Closed

Fix undefined variable and clean up LEDIR #1

wants to merge 15 commits into from

Conversation

lukasm91
Copy link
Collaborator

  • Critical: ISKIP was undefined in the last loop
  • Completely got rid of ISKIP and replace with a simple condition
  • Change the parallelization scheme for simplicity of the code

Note: I applied the 3rd point more widely, but this is yet to come after I checked performance behavior.

  • The change in this PR does not cause significant runtime changes.
  • The change in this PR change results!

@FussyDuck
Copy link

FussyDuck commented Mar 23, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@DJDavies2 DJDavies2 mentioned this pull request Dec 8, 2022
Closed
samhatfield referenced this pull request in samhatfield/ectrans Apr 3, 2024
@ioanhadade
Merge pull request #1 from samhatfield/samhatfield/fix_gpu_omp_ldfou2
ab385ae 
Fix OMP version of loop in LDFOU2
dareg referenced this pull request in dareg/ectrans_nvidia Apr 15, 2024
@marsdeno
Merge pull request #1 from samhatfield/samhatfield/rgo-lumi-fixups
6cd8bd3 
Get redgreen-optimized working on Cray/AMD
@samhatfield samhatfield added question Further information is requested help wanted Extra attention is needed labels Jun 7, 2024
@samhatfield
Copy link
Collaborator

I guess the changes in this PR are already present in @marsdeno's redgreen-optimized. Need to check.

@DJDavies2 DJDavies2 mentioned this pull request Jul 9, 2024
Closed
lukasm91 pushed a commit to lukasm91/ectrans that referenced this pull request Aug 7, 2024
@samhatfield
Merge pull request ecmwf-ifs#1 from marsdeno/rgo-develop-olivier
269d786 
Improved runtime information on GPU binary.
@samhatfield
Copy link
Collaborator

I guess I can close this now @lukasm91?

@lukasm91
Copy link
Collaborator Author

lukasm91 commented Aug 9, 2024

this is ancient, so yes, of course 👍

@lukasm91 lukasm91 closed this Aug 9, 2024
lukasm91 pushed a commit to lukasm91/ectrans that referenced this pull request Sep 3, 2024
@dareg
Merge pull request ecmwf-ifs#1 from lukasm91/already_on_gpu-fix
812aa35 
Fix if data already on device
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsdeno marsdeno Awaiting requested review from marsdeno

Assignees
No one assigned
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukasm91 @FussyDuck @samhatfield