Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Repeat based on Date+Time ECFLOW-1900 #44

Merged
merged 6 commits into from
Feb 8, 2024

Conversation

marcosbento
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 19, 2023

Codecov Report

Attention: 122 lines in your changes are missing coverage. Please review.

Comparison is base (3c7a6a7) 79.95% compared to head (b3e8073) 83.29%.

Files Patch % Lines
ANattr/src/ecflow/attribute/RepeatAttr.cpp 58.50% 83 Missing ⚠️
ANattr/src/ecflow/attribute/RepeatAttr.hpp 60.86% 9 Missing ⚠️
Http/src/ecflow/http/TypeToJson.cpp 40.00% 9 Missing ⚠️
ACore/src/ecflow/core/Chrono.cpp 94.73% 5 Missing ⚠️
ANode/src/ecflow/node/ExprAst.cpp 80.00% 4 Missing ⚠️
ANode/src/ecflow/node/ExprAst.hpp 33.33% 4 Missing ⚠️
ANode/src/ecflow/node/parser/RepeatParser.cpp 82.35% 3 Missing ⚠️
CSim/src/ecflow/simulator/AstAnalyserVisitor.cpp 0.00% 2 Missing ⚠️
ANode/src/ecflow/node/ExprAstVisitor.hpp 50.00% 1 Missing ⚠️
ANode/src/ecflow/node/ResolveExternsVisitor.hpp 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #44      +/-   ##
===========================================
+ Coverage    79.95%   83.29%   +3.34%     
===========================================
  Files          626      594      -32     
  Lines        57824    52953    -4871     
===========================================
- Hits         46233    44109    -2124     
+ Misses       11591     8844    -2747     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcosbento marcosbento changed the title Enable Repeat based on Date+Time Enable Repeat based on Date+Time ECFLOW-1900 Oct 31, 2023
@marcosbento marcosbento force-pushed the feature/ECFLOW-1900_repeat_datetime branch 4 times, most recently from 68602e5 to 757f429 Compare November 17, 2023 17:08
@marcosbento marcosbento force-pushed the feature/ECFLOW-1900_repeat_datetime branch 3 times, most recently from f731e92 to bcf4629 Compare December 8, 2023 11:38
@marcosbento marcosbento force-pushed the feature/ECFLOW-1900_repeat_datetime branch 3 times, most recently from a65f9d2 to 183bebe Compare December 15, 2023 16:44
@marcosbento marcosbento force-pushed the feature/ECFLOW-1900_repeat_datetime branch 4 times, most recently from 1284644 to 4971800 Compare December 21, 2023 12:28
@marcosbento marcosbento force-pushed the feature/ECFLOW-1900_repeat_datetime branch 2 times, most recently from dff7726 to 2adf086 Compare January 8, 2024 11:42
@marcosbento marcosbento force-pushed the feature/ECFLOW-1900_repeat_datetime branch 2 times, most recently from f45b4cd to bae3235 Compare January 17, 2024 11:23
@marcosbento marcosbento force-pushed the feature/ECFLOW-1900_repeat_datetime branch from bae3235 to b3e8073 Compare January 26, 2024 10:38
@marcosbento marcosbento merged commit 30c13c8 into develop Feb 8, 2024
52 checks passed
@marcosbento marcosbento deleted the feature/ECFLOW-1900_repeat_datetime branch February 8, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants