Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve #include structure of commands ECFLOW-1932 #68

Merged
merged 4 commits into from
Dec 8, 2023

Conversation

marcosbento
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2023

Codecov Report

Attention: 240 lines in your changes are missing coverage. Please review.

Comparison is base (6689ac7) 80.16% compared to head (d556f9a) 83.55%.

Files Patch % Lines
Base/src/ecflow/base/cts/task/CtsWaitCmd.cpp 39.16% 87 Missing ⚠️
Base/src/ecflow/base/cts/task/QueueCmd.cpp 70.00% 33 Missing ⚠️
Base/src/ecflow/base/cts/user/MoveCmd.cpp 64.86% 26 Missing ⚠️
Base/src/ecflow/base/cts/task/InitCmd.cpp 60.65% 24 Missing ⚠️
Base/src/ecflow/base/cts/task/LabelCmd.cpp 77.08% 11 Missing ⚠️
Base/src/ecflow/base/cts/task/MeterCmd.cpp 81.35% 11 Missing ⚠️
Base/src/ecflow/base/cts/task/EventCmd.cpp 83.01% 9 Missing ⚠️
Base/src/ecflow/base/cts/task/CompleteCmd.cpp 84.09% 7 Missing ⚠️
Base/src/ecflow/base/cts/task/AbortCmd.cpp 87.23% 6 Missing ⚠️
Base/src/ecflow/base/cts/user/AlterCmd.hpp 94.28% 4 Missing ⚠️
... and 13 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #68      +/-   ##
===========================================
+ Coverage    80.16%   83.55%   +3.39%     
===========================================
  Files          580      589       +9     
  Lines        57925    52566    -5359     
===========================================
- Hits         46434    43921    -2513     
+ Misses       11491     8645    -2846     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcosbento marcosbento force-pushed the feature/improve_command_structure branch from b81e4d7 to d556f9a Compare December 8, 2023 09:52
@marcosbento marcosbento merged commit 7d4b289 into develop Dec 8, 2023
48 checks passed
@marcosbento marcosbento deleted the feature/improve_command_structure branch December 8, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants