Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Enable Aviso notification as trigger ECFLOW-1931 #72

Closed
wants to merge 2 commits into from

Conversation

marcosbento
Copy link
Collaborator

No description provided.

@marcosbento marcosbento changed the title Enable Aviso notification as trigger ECFLOW-1931 {WIP} Enable Aviso notification as trigger ECFLOW-1931 Dec 15, 2023
@marcosbento marcosbento changed the title {WIP} Enable Aviso notification as trigger ECFLOW-1931 WIP Enable Aviso notification as trigger ECFLOW-1931 Dec 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (3c7a6a7) 79.95% compared to head (12e38d2) 83.35%.

Files Patch % Lines
ANode/src/ecflow/node/NodeDelete.cpp 81.03% 11 Missing ⚠️
ANode/src/ecflow/node/NodeChange.cpp 88.88% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #72      +/-   ##
===========================================
+ Coverage    79.95%   83.35%   +3.40%     
===========================================
  Files          626      592      -34     
  Lines        57824    52445    -5379     
===========================================
- Hits         46233    43716    -2517     
+ Misses       11591     8729    -2862     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcosbento marcosbento force-pushed the feature/aviso branch 3 times, most recently from e5f46f3 to 361cd7e Compare December 21, 2023 12:10
@marcosbento marcosbento marked this pull request as draft December 21, 2023 12:28
@marcosbento marcosbento force-pushed the feature/aviso branch 2 times, most recently from 122c551 to 57891b0 Compare January 8, 2024 11:41
@marcosbento marcosbento force-pushed the feature/aviso branch 2 times, most recently from 8773b10 to 3d47952 Compare January 17, 2024 11:24
This set of changes is made as preparation for the addition of an Aviso
attribute, and is expected to reduce the duplication of source code.

Re ECFLOW-1931
Message is a wrapper/utility class that allows to easily create and
store a string based on a set of given arguments.

Re ECFLOW-1931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants