Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilations+static analysis issues #77

Merged
merged 5 commits into from
Jan 8, 2024

Conversation

marcosbento
Copy link
Collaborator

No description provided.

Deleted constructors and assignment operators should have the same
access specifier as other constructors/operators (i.e. public).
Single argument constructors (or any constructor with default
parameters that can be used with single argument) should be marked
explicit to avoid implicit type conversions.

See https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rc-explicit
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b192f43) 79.98% compared to head (8bc33b1) 83.34%.

Files Patch % Lines
Pyext/src/ecflow/python/BoostPythonUtil.cpp 80.00% 2 Missing ⚠️
ACore/test/TestStr.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #77      +/-   ##
===========================================
+ Coverage    79.98%   83.34%   +3.35%     
===========================================
  Files          626      590      -36     
  Lines        58002    52614    -5388     
===========================================
- Hits         46394    43849    -2545     
+ Misses       11608     8765    -2843     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcosbento marcosbento merged commit afd8444 into develop Jan 8, 2024
50 checks passed
@marcosbento marcosbento deleted the feature/static_analysis_issues branch January 8, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants