-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/mpi sendrecv replace #57
Feature/mpi sendrecv replace #57
Conversation
Hi @andreapiacentini - thanks for this PR! Could you sign the ECMWF CLA please. |
Hello @andreapiacentini that looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unit-test required
@dtip do you have any clue why CI is failing? It does not seem related to this PR. |
Yep, it's a permissions issue with accessing the secrets we need to run CI from this public PR. We'll update the CI shortly to fix it. |
@wdeconinck do we want to also modify the CI to compile and test both with and without MPI enabled? |
@wdeconinck I've commited unit tests for these features. |
We've (hopefully) just fixed the CI issue in #58 @andreapiacentini could you rebase this PR onto the latest |
@dtip I did it via the github "Sync fork" link. |
I would definitely suggest to enable MPI. For Atlas and fckit this was enough reason to build eckit as an internal CI cache rather than reuse an existing artifact. It would also be able to test MPI feature changes here rather than offline. |
I think we need to have test with and without MPI. This should be part of the matrix of builds, and we did discuss the possibility of having different builds based on options not only on platforms x compilers. |
Exactly - we can build both with and without MPI with a matrix of build options. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added some cosmetic changes, and tested both with Parallel and Serial backend. All seems to be in good shape.
@dtip something is not right with the GitHub token |
@wdeconinck Yep, the fix we made yesterday didn't work so we've had to revert it. If you're confident with the PR, please feel free to merge it. Otherwise, if you want to run CI, the temporary workaround is to push the come from this PR to a branch within the |
Not tested yet
… validated by experts)
8e21c34
to
52851a3
Compare
This is a tentative implementation of issue #53
It most probably will require some adjustment by the reviewers, especially for the Serial implementation.
Nevertheless, this feature is quite urgently needed for an oops development.
Thanks