Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mapx: TreeMap 添加 Keys 和 Values 方法 #181

Merged
merged 1 commit into from
May 9, 2023
Merged

Conversation

flycash
Copy link
Contributor

@flycash flycash commented May 9, 2023

将原本 Remove 方法改成了 Delete 方法,这算是一个不兼容的修改。不过之前 review 代码的时候没有注意,也没得办法

@flycash
Copy link
Contributor Author

flycash commented May 9, 2023

@juniaoshaonian

@flycash flycash added this to the v0.0.8 milestone May 9, 2023
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #181 (fb3444f) into dev (63b5735) will decrease coverage by 0.31%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #181      +/-   ##
==========================================
- Coverage   95.89%   95.58%   -0.31%     
==========================================
  Files          43       44       +1     
  Lines        2362     2402      +40     
==========================================
+ Hits         2265     2296      +31     
- Misses         77       83       +6     
- Partials       20       23       +3     
Impacted Files Coverage Δ
mapx/hashmap.go 100.00% <ø> (ø)
internal/tree/red_black_tree.go 95.71% <100.00%> (+0.04%) ⬆️
mapx/treemap.go 100.00% <100.00%> (ø)
set/treeset.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@flycash
Copy link
Contributor Author

flycash commented May 9, 2023

组合形态会导致 RBTree 被暴露出去,这是我觉得不能接受的

@flycash flycash merged commit c0c601c into ecodeclub:dev May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant