spi添加 #258
Merged
spi添加 #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
longyue0521
requested changes
May 24, 2024
spi/user_service/a.go
Outdated
| @@ -0,0 +1,25 @@ | |||
| // Copyright 2021 ecodeclub | |||
There was a problem hiding this comment.
- 既然user_service目录和user_service2目录只在测试中使用, 将其移动到/spi/testdata中, 研究一下go中testdata的用法.
- 选择使用go plugin方法实现,需要添加readme,或者Example来一步一步指导用户如何使用
There was a problem hiding this comment.
- 按照 testdata 的用法修改
- 写一个简单的 Example 就可以
longyue0521
requested changes
May 27, 2024
spi/spi_test.go
Outdated
| "github.com/stretchr/testify/assert" | ||
| ) | ||
|
|
||
| func Test_LoadService(t *testing.T) { |
There was a problem hiding this comment.
添加 setupTest方法, 示例如下:
func setupTest(t *testing.T) {
wd, err := os.Getwd()
require.NoError(t, err)
cmd := exec.Command("go", "generate", "./...")
cmd.Dir = filepath.Join(wd, "testdata")
output, err := cmd.CombinedOutput()
require.NoError(t, err, fmt.Sprintf("执行 go generate 失败: %v\n%s", err, output))
}cleanup操作,可选
| dir: "./testdata/user_service2", | ||
| svcName: "UserSvc", | ||
| want: []string{"A", "B"}, | ||
| }, |
There was a problem hiding this comment.
补充测试用例:
- svcName 为空
- svcName 非空但找不到
需要确认LoadService的语义:
dir下非空, ./testdata/user_service3下有 c和d, svcName 也非空, 就是没有与之匹配的,是报错还是返回nil, nil ?
There was a problem hiding this comment.
我直接把，plugin原生的报错吐出去了
There was a problem hiding this comment.
可以自定义一个err说明情况, 然后wrap plugin的err
longyue0521
requested changes
May 29, 2024
spi/spi_test.go
Outdated
| dir string | ||
| svcName string | ||
| want []string | ||
| checkErr func(err error, t *testing.T) |
There was a problem hiding this comment.
改为 assertFunc assert.ErrorAssertionFunc
使用
assertFunc: assert.NoError
assertFunc: assert.Error,
assertFunc: func(t assert.TestingT, err error, i ...interface{}) bool {
return assert.ErrorIs(t, err, DirNotFound)
},| dir: "./testdata/user_service2", | ||
| svcName: "UserSvc", | ||
| want: []string{"A", "B"}, | ||
| }, |
There was a problem hiding this comment.
可以自定义一个err说明情况, 然后wrap plugin的err
longyue0521
requested changes
Jun 2, 2024
longyue0521
requested changes
Jun 3, 2024
longyue0521
approved these changes
Jun 4, 2024
Closed
bigdavidwong
pushed a commit
to bigdavidwong/ekit
that referenced
this pull request
Nov 2, 2024
flycash
pushed a commit
that referenced
this pull request
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
这个测试需要依赖.so文件，直接用cmd命令行创建可行吗