linked_list完成delete方法，linked_list_test新增delete测试用例 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #38 +/- ##
==========================================
+ Coverage 88.54% 89.76% +1.21%
==========================================
Files 7 7
Lines 262 293 +31
==========================================
+ Hits 232 263 +31
+ Misses 27 26 -1
- Partials 3 4 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
flycash
requested changes
Aug 19, 2022
list/linked_list.go
Outdated
| // 删除head | ||
| if index == 0 { | ||
| delVal = l.head.val | ||
| l.head.next.prev = nil |
There was a problem hiding this comment.
你这里会不会 panic？如果我只有一个元素，然后恰好被你删了，head.next 其实是 nil
list/linked_list.go
Outdated
Comment on lines
146
to
147
| tmp := l.tail.prev | ||
| l.tail = tmp |
There was a problem hiding this comment.
l.tail = l.tail.prev 这样应该也可以吧？不需要 tmp 这个中间变量
list/linked_list_test.go
Outdated
Comment on lines
149
to
169
| { | ||
| name: "delete num to index 1", | ||
| list: NewLinkedListOf[int]([]int{11, 22, 33, 44, 55}), | ||
| index: 1, | ||
| delVal: 22, | ||
| wantLinkedList: NewLinkedListOf([]int{11, 33, 44, 55}), | ||
| }, | ||
| { | ||
| name: "delete num to index 2", | ||
| list: NewLinkedListOf[int]([]int{11, 22, 33, 44, 55}), | ||
| index: 2, | ||
| delVal: 33, | ||
| wantLinkedList: NewLinkedListOf([]int{11, 22, 44, 55}), | ||
| }, | ||
| { | ||
| name: "delete num to index 3", | ||
| list: NewLinkedListOf[int]([]int{11, 22, 33, 44, 55}), | ||
| index: 3, | ||
| delVal: 44, | ||
| wantLinkedList: NewLinkedListOf([]int{11, 22, 33, 55}), | ||
| }, |
There was a problem hiding this comment.
这三个测试用例，你只需要保留一个就可以，因为它们其实都命中你删除中间结点的那一个部分。此外，你还需要提供一个额外的测试用例：只有一个元素，然后被你删掉的
There was a problem hiding this comment.
这三个测试用例，你只需要保留一个就可以，因为它们其实都命中你删除中间结点的那一个部分。此外，你还需要提供一个额外的测试用例：只有一个元素，然后被你删掉的
好的
flycash
approved these changes
Aug 20, 2022
flycash
pushed a commit
that referenced
this pull request
Sep 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
linked_list完成delete方法，linked_list_test新增delete测试用例