Clear searches #202
Merged
Clear searches #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgoley
force-pushed
the
clear-searches
branch
from
77584df
to
0392d70
Compare
Broham
reviewed
Dec 15, 2016
| e.preventDefault() | ||
| text = $(e.target).val() | ||
| templateInstance.userSearchText.set(text) | ||
| # 'input .map-search': _.debounce (e, templateInstance) -> |
There was a problem hiding this comment.
Should we just yank the commented out code below?
|
|
||
| Template.searchInput.onCreated -> | ||
| instanceData = @data | ||
| searching = true |
There was a problem hiding this comment.
could these lines be changed to: searching = not instanceData.toggelable?
There was a problem hiding this comment.
I think that would work if we always pass the toggelable property.
Maybe searching = not instanceData.toggelable? would work? But may be confusing.
There was a problem hiding this comment.
searching = not instanceData.toggelable? works in all cases except for when toggleable is set to false. So maybe this:
toggleable = instanceData.toggleable
toggleable ?= false
@searching = new ReactiveVar(not toggleable)
There was a problem hiding this comment.
hrrm - yeah I didn't think of that case. I'd probably just leave it the way it is then.
jgoley
force-pushed
the
clear-searches
branch
from
0392d70
to
5ebf045
Compare
jgoley
force-pushed
the
clear-searches
branch
from
5ebf045
to
c3b0660
Compare
|
looks good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went ahead and created a single template for all the search inputs. I figured it would reduce a fair amount of repetition with clearing inputs and force us into a consistent search UI/UX.
The template receives an object with options including:
textFilter: either areactiveVarorReactiveTableFilteridthe id associated with the element andReactiveTableFilterif its passedpropsif aReactiveTableFilteris not passed, one will be created with theidandpropswhich is an arraytoggleableIf set to true, the input will be initially hidden and appear when the search icon is clicked. When the user clicks on the search icon within the input, the input returns to its hidden state.placeholderdefaults to 'Search'classesclasses which will be applied to the input's parent element