fix #42 #43
Merged
fix #42 #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
| @@ -33,6 +33,17 @@ define( | |||
|
|
|||
| Uploader.prototype.type = 'Uploader'; | |||
|
|
|||
| var mimeTypes = { | |||
There was a problem hiding this comment.
这个不是 mimeType 吧，顶多算 extensionType
|
|
||
| /** | ||
| * 富单选或富复选框组控件 | ||
| * 和BoxGroup的区别：``````选项的文本内容可以含有子控件``````` |
There was a problem hiding this comment.
看看能否改成直接继承 BoxGroup，否则感觉会有不少重复代码
| @@ -528,15 +600,9 @@ define( | |||
| this.notifyFail(options.message); | |||
There was a problem hiding this comment.
这里要改一下，新的 NMP 接口不是返回 "success": true 的。
Justineo
added a commit
that referenced
this pull request
Oct 8, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.