Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

一个比较严重的bundle bug, header上多次添加同一bundle模块url #61

Closed
uraincay opened this issue Jul 17, 2016 · 4 comments
Closed

Comments

@uraincay
Copy link

uraincay commented Jul 17, 2016

// src/main.js
==========
define('A', {}); define('B', {}); define('C', {});
==========

// esl config
==========
baseUrl: src,
bundles: {
    main: ['A', 'B', 'C']
}
==========

 // console输入
require(['A']); require(['B']);

// 结果
==========

d868df7d8196ecdfaaa803f61

hanbf added a commit to hanbf/esl that referenced this issue Jul 18, 2016
- Fix issue ecomfe#61, add check when createScript() for bundles
- Add test in test.html
hanbf added a commit to hanbf/esl that referenced this issue Jul 18, 2016
@hanbf hanbf mentioned this issue Jul 19, 2016
hanbf added a commit to hanbf/esl that referenced this issue Jul 19, 2016
- Fix issue ecomfe#61, add check when createScript() for bundles
- Add test in test.html
hanbf added a commit to hanbf/esl that referenced this issue Jul 19, 2016
@erik168
Copy link
Contributor

erik168 commented Oct 7, 2016

抱歉过这么久才处理,事情太多了。当时我测试过这个东西,确实是有两个script,但是是发的一个请求,所以这事交给浏览器解决了。

@uraincay
Copy link
Author

能否合并下,应该不是所有浏览器都是一个请求的

@leeight
Copy link
Member

leeight commented Jun 27, 2017

简单的测试了一下,感觉应该只有 firefox 下面不太正常,chrome,ie9, ie10 好像是正常的

http://output.jsbin.com/vatidaviso

@leeight
Copy link
Member

leeight commented Jul 19, 2017

貌似最新的 2-2-0 已经没问题了

@leeight leeight closed this as completed Jul 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants