Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent EJS customization #191

Closed
3 tasks done
leomp12 opened this issue Mar 30, 2020 · 0 comments
Closed
3 tasks done

Consistent EJS customization #191

leomp12 opened this issue Mar 30, 2020 · 0 comments
Assignees
@leomp12
Labels
2:medium Not dificult at all ejs Feature/fix for EJS views and prerendered HTML help wanted Extra attention is needed vue New feature or fix for some Vue component

Comments

@leomp12
Copy link
Member

leomp12 commented Mar 30, 2020 •
edited
Loading

Is your feature request related to a problem? Please describe.
Some customization on EJS views/components are overwritten by widgets and Vue components, specially for product card now, it's not intuitive and makes customization harder for partners and merchants.

Describe the solution you'd like

  • Template EJS components may have predefined places for additional HTML;
  • Vue components must have slots to support most common additional HTML cases;
  • Widgets must try to keep custom prerendered HTML, preferably trough respective component slots;

Describe alternatives you've considered
N/A

Additional context
From customization RFC.
@leomp12 leomp12 added help wanted Extra attention is needed 2:medium Not dificult at all vue New feature or fix for some Vue component ejs Feature/fix for EJS views and prerendered HTML labels Mar 30, 2020
@leomp12 leomp12 mentioned this issue Mar 30, 2020
Closed
@leomp12 leomp12 changed the title Consistent prerendered HTML edits Consistent EJS customization Mar 30, 2020
@leomp12 leomp12 self-assigned this Mar 31, 2020
leomp12 added a commit that referenced this issue Apr 3, 2020
@leomp12
fix(ejs): product card and block predefined places for additional HTML
cf0f3d5 
#191

[skip ci]
leomp12 added a commit that referenced this issue Apr 14, 2020
@leomp12
feat(product-card): try some vars from window to customize card
81fe202 
global card customization

#191

[skip ci]
leomp12 added a commit that referenced this issue Apr 14, 2020
@leomp12
feat(widget): properlly handling customization from ejs and cms
78ffb9b 
#191

[skip ci]
leomp12 added a commit that referenced this issue Apr 14, 2020
@leomp12
feat(widget): properlly handling customization from ejs and cms
f843532 
#191

[skip ci]
leomp12 added a commit that referenced this issue Apr 14, 2020
@leomp12
feat(widget-search-engine): using @ecomplus/storefront-components
a70e5bb 
handle customizations with scoped slots

#191

[skip ci]
leomp12 added a commit that referenced this issue Apr 14, 2020
@leomp12
feat(widget-search): using @ecomplus/storefront-components InstantSearch
1e82737 
handle customizations with scoped slots

#191

[skip ci]
leomp12 added a commit that referenced this issue Apr 15, 2020
@leomp12
feat(widget-minicart): using @ecomplus/storefront-components
774c8f1 
handle customization with scoped slots

#191

[skip ci]
leomp12 added a commit that referenced this issue Apr 15, 2020
@leomp12
feat(widget-user): use LoginModal from @ecomplus/storefront-components
06f8230 
handle customization with scoped slots

#191

[skip ci]
@leomp12 leomp12 closed this as completed Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leomp12 leomp12

Labels
2:medium Not dificult at all ejs Feature/fix for EJS views and prerendered HTML help wanted Extra attention is needed vue New feature or fix for some Vue component
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@leomp12