unexpected discrepencies with read_shocks in FramedAgent example

[sbenthall]

Originally discussed here: #1071 (comment)

In the FramedAgent example, I've tried to use the read_shocks functionality to use the exact same shocks in the PortfolioConsumerType and the PortfolioConsumerFrameType, on the theory that the simulation histories should then be identical.

My current use as of #1071 of this isn't working, in that the two simulated shock histories are divergent.

On the other hand, making this change does make the simulation histories look more similar.

Likely there are two issues buried in here: one about proper use of read_shocks, which could be a better documented workflow, and another with the alignment of the simulation mechanics of the framed and unframed models.

[sbenthall]

Related to #863

[sbenthall]

Will revisit this once #1101 is merged to see if that makes a difference, as per @alanlujan91 's suggestion

[sbenthall]

It does look like #1101 helped with this.
But I see now that there are possibly subtle differences in the income process, which I'm still not totally able to replicate in the Frames version of the model, because of some irregularities in how the core IndShock models are designed. I've brought up these design challenges in issue #1111

[sbenthall]

Closing because the FramedAgent is slated for removal