Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sim search b2f #72

Closed
wants to merge 38 commits into from
Closed

Sim search b2f #72

wants to merge 38 commits into from

Conversation

grololo06
Copy link
Member

PR to discuss about changes

py/main.py Outdated Show resolved Hide resolved
@moilerat
Copy link
Collaborator

moilerat commented Dec 22, 2023

@grololo06 : je tente de soumettre ici ce que je m'apprete à faire :

  • Etape 3/4 de la recherche par similarité :
    • Je vais renvoyer des objects EnumeratedObjectSet plutot que DescribedObjectSet,
  • Etape 4/4 de la recherche par similarité :
    • et rajouter un fichier unsupervised.py dans API_models.
    • et j'aurai besoin de requete dans PG que j'espère pouvoir glisser dans des fichiers déjà existant et approprié

Je vais aussi devoir refaire l'etape 2 vu que c'est du code généré (mais pour moi ce n'est pas bloquant pour aller jusqu'au bout de mon POC) (ie generate openapi.json depuis le back et généré le code dans le front à partir de openapi.json)
Et tu me dis avoir un bug dans l'etape 1 (front), mais je ne sais pas comment le reproduire.

Copy link
Member Author

@grololo06 grololo06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few remarks

.github/workflows/auto_tests.yml Outdated Show resolved Hide resolved
py/main.py Outdated Show resolved Hide resolved
py/DB/CNNFeatureVector.py Outdated Show resolved Hide resolved
py/API_models/UnsupervisedSearch.py Outdated Show resolved Hide resolved
py/API_models/filters.py Outdated Show resolved Hide resolved
Copy link
Member Author

@grololo06 grololo06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

J'ai enfin compris comment ça marche!

py/API_operations/imports/Import.py Show resolved Hide resolved
py/API_operations/SimilaritySearch.py Outdated Show resolved Hide resolved
py/API_operations/SimilaritySearch.py Outdated Show resolved Hide resolved
@grololo06
Copy link
Member Author

To redo but not me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants