Skip to content
This repository has been archived by the owner on Feb 20, 2024. It is now read-only.

Add support to retriveSource() method from stripe.js #21

Merged
merged 2 commits into from
Oct 23, 2017

Conversation

mauricioklein
Copy link
Contributor

@mauricioklein mauricioklein commented Oct 20, 2017

The reference to the original method from stripe.js library can be found here

Example of usage:

import { retrieveSource } from 'vue-stripe-elements-plus'

retrieveSource({
   id: "the source ID",
   client_secret: "the client secret"
}).then(response => console.log(response))

Copy link

@lucasrenan lucasrenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but @softbeehive is you guy :)

@23inhouse
Copy link

The stripe.js docs use strings for id and client_secret. I just realized the usage example for this PR has [source ID] but that means variable names not an array?

@mauricioklein
Copy link
Contributor Author

@23inhouse
Sorry, the [] was intended just to show that the information is variable, not that it's actually an array.
I'll adjust that to avoid misunderstanding.

Copy link
Collaborator

@softbeehive softbeehive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump the version in package.json, it's needed for publishing the module

@softbeehive
Copy link
Collaborator

@mauricioklein, can you also tag it, so we can publish it as a release

@mauricioklein
Copy link
Contributor Author

@softbeehive
You mean tag the commit?

@softbeehive
Copy link
Collaborator

@mauricioklein yes, git tag -a v0.2.6 -m 'Add stripe retrieveSource support'

@mauricioklein
Copy link
Contributor Author

@softbeehive Done!

@softbeehive softbeehive merged commit bba4df2 into master Oct 23, 2017
@softbeehive softbeehive deleted the retrieve-source-support branch October 23, 2017 11:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants