* Update dependencies to spomky-labs/jose:^7.0.0 #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ahfeel This update broken CI with error |
|
Mhh, tests are passing successfully, even in the logs of the Travis CI. Do
you have any idea why it failed ?
…On Tue, Jan 23, 2018 at 5:57 PM, Arthur Edamov ***@***.***> wrote:
@ahfeel <https://github.com/ahfeel> This update broken CI with error
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#33 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AACpFh0TABXUE1YBK6e2kRH9i0kCItB8ks5tNg-OgaJpZM4Rer6m>
.
--
Jérémie BORDIER
|
|
Since this is breaking the library for PHP 7.2, maybe it's worth just bumping spomky-labs/jose to 6.1.6 which should be PHP 7.2 compatible? |
|
Sorry, my mistake, looks like unfortunately the change only made it into 7.0. |
|
A don't have any ideas about what is wrong |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update will fetch a whole bunch of packages that are really compatible with php 7.2.