Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add incident_time to dim_discipline_incidents. #74

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Add incident_time to dim_discipline_incidents. #74

merged 1 commit into from
Oct 11, 2023

Conversation

jayckaiser
Copy link
Contributor

For whatever reason, incident_time is absent in dim_discipline_incidents. We should have a discussion about whether to combine incident_date and incident_time into a single column or to leave them separate.

@susanxiong susanxiong self-requested a review September 25, 2023 15:11
@ejoranlienea ejoranlienea merged commit 322e27d into main Oct 11, 2023
@ejoranlienea ejoranlienea deleted the bugfix/discipline_incidents__incident_time branch October 11, 2023 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@susanxiong susanxiong susanxiong approved these changes

@rlittle08 rlittle08 rlittle08 approved these changes

@ejoranlienea ejoranlienea ejoranlienea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jayckaiser @ejoranlienea @rlittle08 @susanxiong