Feature/discipline updates

[jalvord1]

Description & motivation

After seeing multiple examples of how SIS' map their discipline data to the flexible discipline domain and discussing reporting use-cases with the podium team and other implementations, we realized that we needed to update the discipline data model in the warehouse.

Due to the many-to-many relationship between discipline action events/associated disciplines and discipline incidents/associated behaviors and the oftentimes not-analytically meaningful association to IDs, we wanted the ability to report all disciplines/behaviors for a single discipline action event and all disciplines/behaviors for a single discipline incident in new, separated models. These will replace the single model that includes both k_discipline_incident and k_discipline_actions_event.

In addition, we did not previously give users the ability to join all discipline action events/disciplines to all discipline incidents/behaviors (which would represent a different use-case than what is offered via the summary tables), so we are adding a key to join fct_student_discipline_actions and fct_student_discipline_incident_behaviors.

PR Merge Priority:

• Low
• Medium
• High

Changes to existing files:

• dim_discipline_incidents : No changes to the structure, but name is updated to dim_discipline_incident to match the singular pattern of other dimensions. All models that reference this model were also updated to match the new naming convention.
• fct_student_discipline_actions : Carried school_year into the model, added an array of k_student_discipline_incident_behavior to allow for a join against fct_student_discipline_incident_behaviors. Also added example queries to the model documentation.
• fct_student_discipline_incident_behaviors: Added a new key k_student_discipline_incident_behavior for joins against fct_student_discipline_actions.
• fct_student_discipline_incident_behaviors_actions: deleted.

New files created:

• bld_ef3__stu_discipline_action__stu_incident_behavior : The purpose of this model is to create an array of keys of student discipline incident behaviors that are linked to a single discipline action event, for use in fct_student_discipline_actions.
• fct_student_discipline_incident_summary : The purpose of this model is to create a table at the grain of a student and discipline incident that includes an array of all behaviors associated to that incident and an array of all discipline actions associated to that incident regardless of whether or not those discipline actions are associated to multiple action events.
• fct_student_discipline_actions_summary : The purpose of this model is to create a table at the grain of a student and discipline actions event that includes an array of all discipline actions associated to that actions event and an array of all behaviors associated to that event regardless of whether or not those behaviors are associated to multiple incidents.

Tests and QC done:

• Podium team updated the downstream bi models to reference fct_student_discipline_actions_summary and pointed a development version of Podium to the new model. They then QC'd the output and gave a thumbs up that everything looked as expected.
• This has been run in GSN, Denver, TX, and Boston, all of which have different configurations in terms of xwalks & Ed-Fi discipline mapping. Output was expected for each implementation.

NOTE: This branch includes breaking changes