Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build/Learning standards Models #76

Merged
merged 21 commits into from
Nov 29, 2023
Merged

Conversation

AngelicaLastra
Copy link
Contributor

Description & motivation

This PR is linked to edu_edfi_source PR #43 and creates models for learning standard data to be used downstream by student grade tables.

PR Merge Priority:

  • Low
  • Medium
  • High

New files created:

  • dim_learning_standards.sql : This table contains attributes and descriptors for unique Learning Standards.
  • fct_student_learning_standard_grades.sql : This fact table contains student learning standard grades by grading period within the school year. There is one record per student, school, course section, grading period, and learning standard.
  • fct_student_learning_standard_grades.yml and dim_learning_standards.yml : Description for models and columns created.

Tests and QC done:

  • Executed a successful dbt run.
  • Queried both Boston and Jeffco data warehouses to ensure data was accurately populated in the tables.
  • Validated the granularity of the tables by querying each learning standard ID in the learning standard tables and cross-referencing it with a student, course section, school, grading period, and learning standard in the student learning standard grades table.
  • Counted rows throughout to ensure there was no fan out of data, and queried distinct values to ensure data was represented properly.

Future ToDos & Questions:

(based on edu_edfi_source PR #43)

  • There is a question about the grade range a student can earn through a learning standard (what is the max? the min?). We have not yet been able to come to a solution for this since this data doesn't seem to be coming through from the learning standard source (there is an ongoing conversation between Jordan, Rob, and me about this).
  • Academic subject values can sometimes appear cryptic (ex: F1FC8A52-3B53-11E0-B042-495E9DFF4B22 ) however, in other instances, the naming convention is more conventional, such as "Science." We should consider if there's a way to transform them into more readable subject names or if they are helpful as is.
  • Some learning_standard_id values have some helpful descriptions (ex: Math-Effort_rbcX200MATH00000010001111000) while some are less helpful (ex: c86bc12e-e6e3-467b-b8a8-bacc46c95b37) for now we don't do anything with this column but it is something to consider for the future.

models/core_warehouse/dim_learning_standards.sql Outdated Show resolved Hide resolved
models/core_warehouse/dim_learning_standards.sql Outdated Show resolved Hide resolved
models/core_warehouse/dim_learning_standards.sql Outdated Show resolved Hide resolved
models/core_warehouse/dim_learning_standards.yml Outdated Show resolved Hide resolved
models/core_warehouse/dim_learning_standards.sql Outdated Show resolved Hide resolved
models/core_warehouse/dim_learning_standards.yml Outdated Show resolved Hide resolved
@ejoranlienea ejoranlienea merged commit 7924b33 into main Nov 29, 2023
@ejoranlienea ejoranlienea deleted the build/learning_standards branch November 29, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants