Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add warehouse models for cohorts #78

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Conversation

sleblanc23
Copy link
Contributor

@sleblanc23 sleblanc23 commented Oct 20, 2023

Description & motivation

Adds warehouse models for cohorts, per the EDU Project Development board.

Requires a field added to stg_ef3__cohorts in this PR.

PR Merge Priority:

  • Low

New files created:

  • dim_cohort.sql
  • fct_student_cohort_association.sql

Tests and QC done:

  • Ran the models successfully in GSN and South Carolina

Future ToDos:

No implementations have data for staffCohortAssociations yet. I added a Monday task to build fct_staff_cohort_association once we have a use case.

@ejoranlienea
Copy link
Contributor

Looks good.
Two thoughts:

  1. Could consider adding an active indicator, like student_school_association has
  2. Given how rarely (if ever) we've seen this data in the wild, I wonder if we should tag this under its own domain here and in source so that we can disable it when not in use.

@sleblanc23
Copy link
Contributor Author

@ejoranlienea

I added an active indicator and a cohort tag so we can disable these when they're not needed. Also opened a PR in source for those models. Am I missing anything for adding that tag?

@ejoranlienea ejoranlienea merged commit a870f6f into main Nov 29, 2023
@ejoranlienea ejoranlienea deleted the feature/cohorts branch November 29, 2023 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants