-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edbee corrupts when setting a reloaded theme #26
Comments
I expect that reloading a theme destoys the original theme object. And the editor still refers to the first assigned pointer... I will write a test for it and I guess I need to implement an signal that the theme are reloaded and the pointers are invalid. So all involved objects can refetch the newly loaded theme |
Thanks - being able to reload a theme would be good, as it'll cover the case that a theme might have been online and needs to be reloaded. It also seems that I'm able to set the theme both in the documents config and in the editors config - I should only be setting it in the former, right? |
edbee has been merged into |
…ointer used by the renderer. (Fixes corruption on theme reloading) fix #25, Removed the 'memory ok :-D' message
I hope this commit solves the issue. (I'm not sure about it). |
Nice that edbee has been merged 😄 !! |
Works! Thank you! |
I'm downloading new themes from the web and would like them refreshed in edbee, so I'm calling
themeManager->readThemeFile()
andconfig->setThemeName()
again. It works fine on the first go but the second time this is done, edbee painting stuffs up and eventually crashes:Any idea how I'm misusing the API? The code to load the themes is here and to set the theme is the next slot definition after.
The text was updated successfully, but these errors were encountered: