Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edbee corrupts when setting a reloaded theme #26

Closed
vadi2 opened this issue Jun 9, 2017 · 6 comments
Closed

edbee corrupts when setting a reloaded theme #26

vadi2 opened this issue Jun 9, 2017 · 6 comments

Comments

@vadi2
Copy link
Contributor

vadi2 commented Jun 9, 2017

I'm downloading new themes from the web and would like them refreshed in edbee, so I'm calling themeManager->readThemeFile() and config->setThemeName() again. It works fine on the first go but the second time this is done, edbee painting stuffs up and eventually crashes:

peek 2017-06-09 21-31

Any idea how I'm misusing the API? The code to load the themes is here and to set the theme is the next slot definition after.

@gamecreature
Copy link
Member

gamecreature commented Jun 10, 2017

I expect that reloading a theme destoys the original theme object. And the editor still refers to the first assigned pointer...
I will check it out.

I will write a test for it and I guess I need to implement an signal that the theme are reloaded and the pointers are invalid. So all involved objects can refetch the newly loaded theme

@vadi2
Copy link
Contributor Author

vadi2 commented Jun 10, 2017

Thanks - being able to reload a theme would be good, as it'll cover the case that a theme might have been online and needs to be reloaded.

It also seems that I'm able to set the theme both in the documents config and in the editors config - I should only be setting it in the former, right?

@vadi2
Copy link
Contributor Author

vadi2 commented Jun 10, 2017

edbee has been merged into development in Master by the way - so it'll be in the hands of our users in a couple of weeks in July!

gamecreature added a commit that referenced this issue Jun 10, 2017
…ointer used by the renderer. (Fixes corruption on theme reloading)

fix #25, Removed the 'memory ok :-D' message
@gamecreature
Copy link
Member

I hope this commit solves the issue. (I'm not sure about it).
It resolves the suspicion I have with the error...

@gamecreature
Copy link
Member

Nice that edbee has been merged 😄 !!

@vadi2
Copy link
Contributor Author

vadi2 commented Jun 11, 2017

Works! Thank you!

@vadi2 vadi2 closed this as completed Jun 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants