Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BH 1.81.0 upgrade plan #88

Closed
6 tasks done
eddelbuettel opened this issue Dec 16, 2022 · 10 comments
Closed
6 tasks done

BH 1.81.0 upgrade plan #88

eddelbuettel opened this issue Dec 16, 2022 · 10 comments

Comments

@eddelbuettel
Copy link
Owner

eddelbuettel commented Dec 16, 2022

Boost released 1.81.0 this week, and the BH package was updated to release 1.81.0-0 in PR #87. It can be accessed from the ghrr drat via

install.packages("BH", repos=c("https://ghrr.github.io/drat", "https://cloud.r-project.org"))

and similarly from r-universe. As usual we ran full reverse-dependency checks on Debian testing system (where gcc-12 is the default). The logs are in this commit at the rcpp-logs repo are reveal issues in these six packages

  • colourvalues (2 out of 523 tests fail) (maintainer emailed 2022-12-15) (PR #77 made 2022-12-19) (heard back 2022-12-21 'mid-January should work') (merged 2022-12-29) (version 0.3.8 on CRAN 2023-02-06)
  • httpgd (compilation error on string_view) (maitainer emailed 2022-12-15) (heard back 2022-12-16, package fix by January planned) (version 1.3.0 on CRAN 2023-02-02)
  • rgeoda (compilation error, possibly only missing an include) (unrelated to BH, g++-12 issue) (PR #4 made 2022-12-16 in related library repo) (merged 2023-01-01) (version 0.0.10-2 on CRAN 2023-01-30)
  • rlas (compilation issue from g++-12?) (unrelated to BH, g++-12 issue) (PR #57 made 2022-12-16) (merged 2022-12-16) (version 1.6.2 on CRAN 2023-01-06)
  • rstan (possibly more complex Boost Phoenix issue) (maintainer emailed 2022-12-16) (heard back 2022-12-16: 'soon') (heard back 2022-12-26 linker issue addressed, rest possibly more involved) (version 2.21.8 on CRAN 2023-01-17)
  • TDA (issue with Boost's vector) (maintainer emailed 2022-12-16) (heard back 2022-12-26, 'January should be fine') (version 1.9 on CRAN 2023-02-04)

I have or will contact all maintainers by either email or PR. The plan would be to get all packages fixed in four weeks from now to permit a mid-January CRAN upload of BH 1.81.0.

Edit 2022-12-30 We now have 1.81.0-1 (via #90) which had another round of reverse-depends checks which revealed no new or changed issue.

@nx10
Copy link

nx10 commented Jan 8, 2023

I just submitted httpgd 1.3.1 which should resolve this issue (for httpgd): http://nx10.github.io/cransubs/pkg#httpgd

If anyone is interested in the fix, boost::beast string views switched internally from boost::detail::basic_string_view to boost::core::basic_string_view in the latest version. Of these the current one does not have a .to_string() method.

Edit: It was rejected in pretest due to (I believe) (#89). I have informed CRAN.

@eddelbuettel
Copy link
Owner Author

Thank you so much, also for the added color. I have seen boost::core::* pop up in the context of the 'grand ole sprintf replacement' as there is a (pending/coming) boost::core::snprintf that I aded in 1.81.0-1 in order to minimize that issue.

(And good luck with CRAN. I always found them reasonable when I replied on such false positives. And an updated BH will be coming if all goes well by mid-Jan. Speaking of which, any update from the stan world @bgoodri ?)

@bgoodri
Copy link

bgoodri commented Jan 9, 2023

I have a real fix. Just testing the reverse dependencies.

@eddelbuettel
Copy link
Owner Author

I would like to upload BH in the next few days. Of the six packages, only one (rlas) made it through. Uploading may help another (httpgd). I hope it may help rstan, colorvalues, TDA.

Thoughts?

@bgoodri
Copy link

bgoodri commented Jan 17, 2023

I uploaded rstan to CRAN. It should be fine, but won't be approved until tomorrow at the earliest.

@eddelbuettel
Copy link
Owner Author

eddelbuettel commented Jan 17, 2023

Cool, thanks for the update! I will try to follow-up with BH and we can continue to coordinate here.

Edit: With rstan now on CRAN I will likely follow suit very shortly.

@nx10
Copy link

nx10 commented Jan 22, 2023

Seems like BH 1.81 is now on CRAN. httpgd will follow up shortly

@eddelbuettel
Copy link
Owner Author

Correct. It is now up on CRAN, I mentioned this issue, the two closed one and your 'pending' httpgd as open but imminently addressable and so it was moved ahead by the CRAN maintainers after a few days.

I will close this issue as completed, we can still discuss here needed.

Big big thanks to everybody for the prompt help.

@eddelbuettel
Copy link
Owner Author

@nx10: Yay!

image

Glad to see it back!

@nx10
Copy link

nx10 commented Jan 30, 2023

Thanks! They requested a couple documentation changes so it got delayed again. 2.0 soon™

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants