-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose the C hash functions #10
Conversation
Looks like a very good start! I am not sure I would declare everything in And if I may: as you took inspiration from xts's header, would you mind adding me to the copyright header? |
Oh, I originally want to deal with all C hash functions. Limiting to murmurhash sounds good since I am not going to test the others recently. And yes, I would add you to the copyright headers to I'll submit the changes after Xmas Day. Happy Xmas Day |
I think we are on the same page. I also want to make all the C level functions available (at the source level) to other R packages. But the currently chosen method is probably the most laborious (yet trusted) so I'd say let do this one now for just pmurmurhash. I can also quickly edit this at my end. |
- add header guard to exported header
This might be what we need so far. I test the exposed |
Expose the C hash functions
That looks pretty good -- thanks for the update! I will give this one more look-over, try to address one open issue with pmurmurhash (see #9) and then ship this to CRAN so that you can depend on it. A bit more medium term, we will work out the best way to expose functions (which may just be what you had in init.c, or one of the other previously discussed methods) and maybe create an example package using it. |
Made a minor edit in init.c, added something in ChangeLog for your changes and bumped Date: and Version: |
wush978/FeatureHashing#26
init.c