Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upConvert POSIXct to Date directly #2
Merged
Conversation
As of R-3.5.1, converting from POSIXct to Date creates an intermediate POSIXlt vector. This uses a non-trivial amount of memory. Directly converting from POSIXct to Date uses less memory and is roughly twice as fast. This solution is a combination of asPOSIXlt and POSIXlt2D from RCore. The functions are essentially concatenated, with the extraneous parts removed. The function name 'asDatePOSIXct' differs from the other rapi* names because it's not a RCore function. The name isn't as.Date.POSIXct() to avoid clashes with the current (or future) S3 method.
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
==========================================
+ Coverage 53.24% 54.67% +1.42%
==========================================
Files 5 6 +1
Lines 971 1017 +46
==========================================
+ Hits 517 556 +39
- Misses 454 461 +7
Continue to review full report at Codecov.
|
|
Looks fabulous, and helpful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
As of R-3.5.1, converting from POSIXct to Date creates an intermediate
POSIXlt vector. This uses a non-trivial amount of memory. Directly
converting from POSIXct to Date uses less memory and is roughly twice
as fast.
This solution is a combination of asPOSIXlt and POSIXlt2D from RCore.
The functions are essentially concatenated, with the extraneous parts
removed.
The function name 'asDatePOSIXct' differs from the other rapi* names
because it's not a RCore function. The name isn't as.Date.POSIXct() to
avoid clashes with the current (or future) S3 method.