-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: download quantlib on macos if not found locally #176
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks promising. Is that 'mac' directory at CRAN browseable?
The build works, but one of your tests has a weird error: Lines 38 to 49 in 8540c94
|
Is it my tests, or my 'ad-hoc' build script used by the test? It could just be the latter. Feel free for brute force testing to comment out the overtall hook into |
OK I disabled that test on mac (that was already disabled on windows) so the build passes now. |
Nice. In the flurry you may have missed what I asked earlier
I.e. can I know how old his packages are? But I answered that by pointing a browser at https://mac.r-project.org/bin/darwin20/arm64/. Looks like Simon updates once a year or more often if he musts. |
They updated the libs last month for the R 4.3 release, but I suspect not much updates for another 2 years after this until they bump to a new macos version. |
Of course now I have to figure out how to only trigger macOS when I have the patience for it :) |
The build will be a bit faster if you mirror those 4 files to some of faster server (or just anywhere on github): Lines 93 to 99 in af4e4c6
Either way good luck, I'm done for the day. |
This will allow the package to be built in CI or r-universe or by mac users locally, with the same quantlib as CRAN.
On systems where
quantlib-config
is found (such as cran itself), that configuration is used, and nothing is downloaded. So it functions as a fallback method for mac systems where quantlib is not available.PS: if you use this, I recommend mirroring the downloaded files from cran somewhere (e.g. github release assets) because
mac.r-project.org
is pretty slow and flaky.