just more helpful tips about 'invert' tag #14
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddieantonio
requested changes
Jul 24, 2019
There was a problem hiding this comment.
Because this repo is in general use (not just @UAlbertaALTLab, but elsewhere too), I think it is inappropriate to put this note here. Please move this note to UAlbertaALTLab/plains-cree-fsts!
| > try to loading the FST inverted first if `.generate()` or `.analyze()` | ||
| > aren't working correctly! | ||
|
|
||
| > If you are working with [plain cree fomabins](!https://github.com/UAlbertaALTLab/plains-cree-fsts/releases) specifically, load generator files inverted; load analyzer files normally. |
There was a problem hiding this comment.
Suggested change
| > If you are working with [plain cree fomabins](!https://github.com/UAlbertaALTLab/plains-cree-fsts/releases) specifically, load generator files inverted; load analyzer files normally. |
There was a problem hiding this comment.
Note: I already moved this comment to ualbertaaltlab/plains-cree-fsts, so just delete it from here.
|
*bump* @Madoshakalaka please address the review comments! |
|
Closing this PR due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.