More wrappers #35
Merged
More wrappers #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UINavigationBar wrappers (#34)
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
+ Coverage 99.74% 99.74% +<.01%
==========================================
Files 11 13 +2
Lines 393 399 +6
==========================================
+ Hits 392 398 +6
Misses 1 1 |
|
Thanks! Sorry for the delay -- will take a closer look at this later today or tomorrow. |
eddiekaiger
requested changes
Jun 5, 2019
|
|
||
| - parameter attrs: The attributes to use. | ||
| */ | ||
| public func size(withSwiftyAttributes attrs: [Attribute]? = nil) -> Size { |
There was a problem hiding this comment.
I'd leave out the default parameter here because then size() will be ambiguous.
There was a problem hiding this comment.
Hello @eddiekaiger
What about the swifty_ prefix for all these functions?
| - parameter swiftyAttributes: The attributes to use. | ||
| - parameter context: Drawing context. | ||
| */ | ||
| public func boundingRect(with size: Size, options: DrawingOptions = [], swiftyAttributes: [Attribute]? = nil, context: DrawingContext?) -> Rect { |
There was a problem hiding this comment.
same here, I'd leave out the default parameter for swiftyAttributes
| - parameter swiftyAttributes: The attributes to use. | ||
| */ | ||
| @available(macOS, deprecated: 10.12) | ||
| public func boundingRect(with size: Size, options: DrawingOptions = [], swiftyAttributes: [Attribute]? = nil) -> Rect { |
| public typealias Point = CGPoint | ||
| public typealias Size = CGSize | ||
| public typealias Rect = CGRect | ||
| public typealias DrawingOptions = NSStringDrawingOptions |
There was a problem hiding this comment.
could we maybe move these to the files where they're used? The other typealiases are declared here because they're used in this file
eddiekaiger
approved these changes
Jun 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
As I wrote before here is a pull request with more wrappers. However I don't know how can I write tests for these functions to pass the Codecov check.