-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fix for iOS when app is killed app #56
base: master
Are you sure you want to change the base?
Conversation
I have merged #46, as Android was not working in the background. And that PR hasn't been merged for months. It should now be fully working for both Android & iOS when the App is killed (both Android <8 and 8+). I have modified it, so you can specify your own title/text and icon for the ongoing notification.
It seems like there hasn't been any update on that repo for months, I wonder if we should move to another repo and maintain it? |
Changing repos may be useful. We would want to make sure that we upload the new version to npm as well. :) |
Whats the status on this @NuclearKev @cladjules ? Will this be released in some way? |
I tested it in iOS, it is working well. The package should be released soon? @NuclearKev @cladjules |
@cladjules I am suddenly facing several new issues. Might be related to issues with new Android patches? (I know they worked a bit on these APIs for the Corona Apps) Sometimes it fails to add geofences.
and the function is rejected with an error with the message Secondly, it happens quite often (more or less 50% of the time) that geofence crossings are not reported when the app is killed. This was working pretty stable before. Any idea what could be the reason for this? @NuclearKev do you face the same behavior? |
Thanks for this great work and it works in ios without any issues but I also get the same issue in android now. and is giving me the error Would it be possible for you @cladjules @NuclearKev to check this and help.It would be really helpful it this gets resolved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have u test this? is this running fine?
Would it also work for android 10+, given the baclground restrictions that were introduced? |
I've been using the a fork of this on Android 10+ for months and it's been working fine. You just need to make sure you have the correct permissions enabled. Here is the fork if you want to use it. https://github.com/skedlife/react-native-boundary |
Use hasListeners to check whether or not listeners have been added yet.
Queue the listeners and once the listeners are added, send them to the event.