Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite in React #487

Open
4 of 10 tasks
edemaine opened this issue Sep 21, 2020 · 0 comments
Open
4 of 10 tasks

Rewrite in React #487

edemaine opened this issue Sep 21, 2020 · 0 comments
Labels
speed

Comments

@edemaine
Copy link
Owner

edemaine commented Sep 21, 2020 •
edited
Loading

I conjecture that we'll get substantially better performance by rewriting all templates in React. Worth testing in a minimal setting (probably the message template which has the most performance issues, or perhaps the simpler users template) to make sure. Meteor supports mixing Blaze and React during such transitions.

Priorities:

  • message/submessage (~5-6x speed boost thanks to also removing tooltips)
  • group (1.5x speed boost?)
  • users (~2x speed boost)
  • stats
  • search
  • settings
  • layout
  • Remainder
  • Port remaining uses of tooltip and dropdown JavaScript to React Bootstrap, and then we can remove client/bootstrap/bootstrap.min.js... except for Scrollspy
  • Switch from Iron Router to React Router (including remembering page scroll etc.)
@edemaine edemaine added the speed label Sep 21, 2020
@edemaine edemaine mentioned this issue Dec 11, 2020
Open
This was referenced Jan 13, 2021
Merged
Closed
edemaine added a commit that referenced this issue Jan 14, 2021
@edemaine
Users view port to React (#487)
fd04b45 
Roughly 2x faster
edemaine added a commit that referenced this issue Jan 17, 2021
@edemaine
Group view port to React (#487)
9fa0585
edemaine added a commit that referenced this issue Jan 17, 2021
@edemaine
Group view port to React (#487)
bc1f952
edemaine added a commit that referenced this issue Jan 23, 2021
@edemaine
Statistics port to coauthors and React (#487, #503)
9707e8b 
* No longer care about @mentioned messages, so removed that dropdown.
* Also fix inconsistencies about deleted and unpublished messages
  being included (shouldn't have been).
@edemaine edemaine mentioned this issue Feb 1, 2022
Open
12 tasks
@edemaine edemaine mentioned this issue Apr 22, 2022
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
speed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edemaine