Network selector #454
Merged
Network selector #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavier506
reviewed
May 7, 2021
|
|
||
| NetworkSelector.defaultProps = { | ||
| title: '', | ||
| options: [ |
There was a problem hiding this comment.
are we setting these as environmental variables?
We currently don't have a Telos or Wax instance running
xavier506
reviewed
May 7, 2021
| "/lacchain/network>sidebar": "LACChain Topologia de rede", | ||
| "/lacchain/network>title": "LACChain Topologia de rede - Panel", | ||
| "/lacchain/network>heading": "LACChain Topologia de rede", | ||
| "/lacchain/network>sidebar": "Topologia de red", |
There was a problem hiding this comment.
xavier506
reviewed
May 7, 2021
.env.lacchain
Outdated
| REACT_APP_TOKEN_SYMBOL= | ||
| REACT_APP_EOS_MAINNET=https://mainnet.eosio.cr | ||
| REACT_APP_JUNGLE_TESTNET=http://testnet.eosio.cr |
There was a problem hiding this comment.
we should add these variables to the remaining .env files also
adriexnet
approved these changes
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network selector
What does this PR do?
Steps to test
make run lacchainCheckList