-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/automatic removal #379
Conversation
if (!link || !session) { | ||
localStorage.setItem('isActiveSession', false) | ||
return | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After the app is updated, the user may lose session producing conflicts trying to re-log, this validation fix that issue
if (!daysAfterJoin || hasKYC) continue | ||
|
||
if ( | ||
daysAfterJoin === Math.round(removeAfterDays * 0.2) && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xavier506 please validate this logic, I did a little modification to the discussion proposal, I said after the first week, but that may be too static, I changed it to send the first warning mail after 2/10 of expiration_days
have passed since the application.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you prefer the static approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good , more dynamic!
@leisterfrancisco please see code factor issues |
I did, but I'm not sure about those suggestions, what happened is that the code factor doesn't like the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Remove join request user automatically
What does this PR do?
Steps to test
make run