Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/automatic removal #379

Merged
merged 8 commits into from
Feb 1, 2022
Merged

Feat/automatic removal #379

merged 8 commits into from
Feb 1, 2022

Conversation

leisterfrancisco
Copy link
Collaborator

Remove join request user automatically

What does this PR do?

Steps to test

  1. make run

@leisterfrancisco leisterfrancisco self-assigned this Jan 31, 2022
@leisterfrancisco leisterfrancisco added the WIP Work In Progress label Jan 31, 2022
Comment on lines +96 to +99
if (!link || !session) {
localStorage.setItem('isActiveSession', false)
return
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the app is updated, the user may lose session producing conflicts trying to re-log, this validation fix that issue

@leisterfrancisco leisterfrancisco removed the WIP Work In Progress label Jan 31, 2022
if (!daysAfterJoin || hasKYC) continue

if (
daysAfterJoin === Math.round(removeAfterDays * 0.2) &&
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xavier506 please validate this logic, I did a little modification to the discussion proposal, I said after the first week, but that may be too static, I changed it to send the first warning mail after 2/10 of expiration_days have passed since the application.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you prefer the static approach.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good , more dynamic!

@xavier506
Copy link
Contributor

@leisterfrancisco please see code factor issues

@leisterfrancisco
Copy link
Collaborator Author

leisterfrancisco commented Feb 1, 2022

@leisterfrancisco please see code factor issues

I did, but I'm not sure about those suggestions, what happened is that the code factor doesn't like the join_request format name. I'm doing an object destructuring which is a format name that I can't change, a solution for this issue is to save the coming data into a variable without destructuring it and later access it with something like result.join_request but not sure if it is a convention in the team to avoid this kind of code factor issue, please, let me know to make the update.

@xavier506

Copy link
Contributor

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit 1735fe1 into dev Feb 1, 2022
@xavier506 xavier506 deleted the feat/automatic-removal branch February 1, 2022 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove pending KYC user automatically
2 participants