Cortex-M3 patch

[ryos36]

Hi,
This is Cortex-M3 patch for tlmu/QEMU.

[edgarigl]

Thanks Ryos!

Could you please add a Signed-off-by line on the commit message and also add a comment in the code describing what the bit masking/unmasking is actually doing?

Thanks again!
Edgar

[ryos36]

Hi,

Here is the patch. Is it OK?
and also, I have pushed the patch into my tlmu clone in github.

set SPSEL bit ( 0 = MSP, 1 = PSP ), when switch_v7m_sp

Signed-off-by: Ryos Suzuki <ryos@sinby.com>

diff --git a/target-arm/helper.c b/target-arm/helper.c
index d3a3ba2..d0bc049 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -725,6 +725,13 @@ static void switch_v7m_sp(CPUARMState *env, int process)
env->v7m.other_sp = env->regs[13];
env->regs[13] = tmp;
env->v7m.current_sp = process;
+

•   /\* set SPSEL bit ( 0 = MSP, 1 = PSP ) */
  

•   if ( process ) {
  

•        env->v7m.control |= 0x2;
  

•   } else {
  

•        env->v7m.control &= ~0x2;
  

•   }
  

  }
  }

[edgarigl]

On Wed, Jul 11, 2012 at 09:38:25PM -0700, Ryos Suzuki wrote:

Hi,

Here is the patch. Is it OK?

Hi,

Sorry for the delay. The patch looks OK. I'm currently traveling
and will apply this once I'm back!

thanks,
Edgar

and also, I have pushed the patch into my tlmu clone in github.

set SPSEL bit ( 0 = MSP, 1 = PSP ), when switch_v7m_sp

Signed-off-by: Ryos Suzuki <ryos@sinby.com>

diff --git a/target-arm/helper.c b/target-arm/helper.c
index d3a3ba2..d0bc049 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -725,6 +725,13 @@ static void switch_v7m_sp(CPUARMState *env, int process)
env->v7m.other_sp = env->regs[13];
env->regs[13] = tmp;
env->v7m.current_sp = process;
+

•   /\* set SPSEL bit ( 0 = MSP, 1 = PSP ) */
  

•   if ( process ) {
  

•        env->v7m.control |= 0x2;
  

•   } else {
  

•        env->v7m.control &= ~0x2;
  

•   }
  

  }
  }

---

Reply to this email directly or view it on GitHub:
#2 (comment)

[edgarigl]

On Wed, Jul 11, 2012 at 09:38:25PM -0700, Ryos Suzuki wrote:

Hi,

Here is the patch. Is it OK?
and also, I have pushed the patch into my tlmu clone in github.

set SPSEL bit ( 0 = MSP, 1 = PSP ), when switch_v7m_sp

Signed-off-by: Ryos Suzuki <ryos@sinby.com>

Hi,

Sorry for the delays, I've been travelling for a while.

Thanks for the updated patch.

An easy way to check for patch style correctness is to use
the checkpatch script. For example to check the latest
commit:

git show | ./scripts/checkpatch.pl -

I've comitted the following:

commit 234773d
Author: Ryos Suzuki ryos@sinby.com
Date: Wed Aug 1 19:04:36 2012 +0200

arm: set SPSEL bit (0 = MSP, 1 = PSP), when switch_v7m_sp

Signed-off-by: Ryos Suzuki <ryos@sinby.com>
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@gmail.com>

diff --git a/target-arm/helper.c b/target-arm/helper.c
index d3a3ba2..bf2030d 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -725,6 +725,13 @@ static void switch_v7m_sp(CPUARMState *env, int process)
env->v7m.other_sp = env->regs[13];
env->regs[13] = tmp;
env->v7m.current_sp = process;
+

•    /\* set SPSEL bit ( 0 = MSP, 1 = PSP ) */
  

•    if (process) {
  

•        env->v7m.control |= 0x2;
  

•    } else {
  

•        env->v7m.control &= ~0x2;
  

•    }
  

  }
  }