Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement get_*_properties in client #231

Merged
merged 1 commit into from
Feb 15, 2022
Merged

Conversation

edgarrmondragon
Copy link
Owner

@edgarrmondragon edgarrmondragon commented Feb 15, 2022

Closes #228
Closes #229
Closes #230

@edgarrmondragon edgarrmondragon self-assigned this Feb 15, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@edgarrmondragon edgarrmondragon added RPC Issues related to the RPC client implementation enhancement New feature or request labels Feb 15, 2022
@edgarrmondragon edgarrmondragon changed the title feat: implement get_*_properties in client feat: implement get_*_properties in client Feb 15, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #231 (928a918) into master (a892f87) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #231   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          228       234    +6     
  Branches        26        26           
=========================================
+ Hits           228       234    +6     
Impacted Files Coverage Δ
src/citric/client.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a892f87...928a918. Read the comment docs.

@edgarrmondragon edgarrmondragon merged commit cba45c9 into master Feb 15, 2022
@edgarrmondragon edgarrmondragon deleted the get-properties branch February 15, 2022 00:07
@edgarrmondragon edgarrmondragon added this to the Full API coverage milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request RPC Issues related to the RPC client implementation
Projects
2 participants