Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update alloy dependencies, fix a few small graphql test/export issues #17

Merged
merged 4 commits into from
Oct 12, 2023

Conversation

Jannis
Copy link
Collaborator

@Jannis Jannis commented Oct 12, 2023

No description provided.

Without the explicit crate prefix, the compiler is getting confused
about whether the internal graphql module or the external graphql
dependency is being exported.
@Jannis Jannis requested review from LNSD and Theodus October 12, 2023 14:39
Copy link
Member

@Theodus Theodus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@LNSD LNSD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@Jannis Jannis merged commit 67d3423 into main Oct 12, 2023
5 checks passed
@Jannis Jannis deleted the jannis/update-alloy branch October 12, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants