Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miniconstellation e2e test #1490

Merged
merged 4 commits into from
Mar 23, 2023
Merged

miniconstellation e2e test #1490

merged 4 commits into from
Mar 23, 2023

Conversation

3u13r
Copy link
Member

@3u13r 3u13r commented Mar 22, 2023 •
edited
Loading

Proposed change(s)

  • the main change is that the miniconstellation e2e test is now a bazel target which can be executed with bazel run //e2e/miniconstellation:miniconstellation_test_e2e_remote
  • This target is then used inside the CI e2e test
  • This fixes that errors in the test were not reported by the CI.

CI run: https://github.com/edgelesssys/constellation/actions/runs/4490634835/jobs/7898287803

I'd suggest to review this commit by commit, as there are changes in different areas.

Checklist

  • Add labels (e.g., for changelog category)
  • Link to Milestone

@3u13r 3u13r added the no changelog Change won't be listed in release changelog label Mar 22, 2023
@3u13r 3u13r added this to the v2.7.0 milestone Mar 22, 2023
@3u13r 3u13r changed the title Test/ci/mini constellation miniconstellation e2e test Mar 22, 2023
@netlify
Copy link

netlify bot commented Mar 22, 2023 •
edited
Loading

✅ Deploy Preview for constellation-docs canceled.

Name Link
🔨 Latest commit 6d57c43
🔍 Latest deploy log https://app.netlify.com/sites/constellation-docs/deploys/641c53b19daed60008fa2da9

@3u13r 3u13r temporarily deployed to e2e March 22, 2023 12:51 — with GitHub Actions Inactive
@3u13r 3u13r force-pushed the test/ci/miniConstellation branch from 947b546 to 8a1020e Compare March 22, 2023 13:14
@3u13r 3u13r temporarily deployed to e2e March 22, 2023 13:28 — with GitHub Actions Inactive
@3u13r 3u13r force-pushed the test/ci/miniConstellation branch from 8a1020e to 77bbcaf Compare March 22, 2023 13:54
@daniel-weisse daniel-weisse removed their request for review March 22, 2023 14:03
@3u13r 3u13r temporarily deployed to e2e March 22, 2023 14:07 — with GitHub Actions Inactive
katexochen
katexochen reviewed Mar 23, 2023
View reviewed changes
Copy link
Member

@katexochen katexochen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this locally, works great!

e2e/miniconstellation/BUILD.bazel Outdated Show resolved Hide resolved
e2e/miniconstellation/.gitignore Outdated Show resolved Hide resolved
e2e/miniconstellation/test-remote.sh Outdated Show resolved Hide resolved
@3u13r
Copy link
Member Author

3u13r commented Mar 23, 2023 •
edited
Loading

new run: https://github.com/edgelesssys/constellation/actions/runs/4499149223/jobs/7916641237
latest run: https://github.com/edgelesssys/constellation/actions/runs/4499149223/jobs/7917296831

@3u13r 3u13r requested a review from katexochen March 23, 2023 12:07
@3u13r 3u13r force-pushed the test/ci/miniConstellation branch from bffb553 to 6d57c43 Compare March 23, 2023 13:27
@3u13r 3u13r merged commit 18661ce into main Mar 23, 2023
@3u13r 3u13r deleted the test/ci/miniConstellation branch March 23, 2023 13:55
@derpsteb derpsteb mentioned this pull request Mar 24, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katexochen katexochen katexochen approved these changes

@derpsteb derpsteb Awaiting requested review from derpsteb derpsteb is a code owner

Assignees
No one assigned
Labels
no changelog Change won't be listed in release changelog
Projects
None yet
Milestone
v2.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@3u13r @katexochen