AB#2578 Implement Azure IAM in terraform #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for constellation-docs canceled.
|
msanft
force-pushed
the
feat/TerraformAzureIAM
branch
from
347830d
to
385655e
Compare
msanft
force-pushed
the
feat/TerraformAzureIAM
branch
from
385655e
to
4043510
Compare
malt3
reviewed
Nov 16, 2022
malt3
suggested changes
Nov 16, 2022
hack/terraform/azure/iam/readme.md
Outdated
| @@ -0,0 +1,37 @@ | |||
| # IAM instance for Azure | |||
There was a problem hiding this comment.
very subjective nit: I would change the filename to README.md for consistency.
hack/terraform/azure/iam/readme.md
Outdated
| ```sh | ||
| mkdir constellation_azure_iam | ||
| cd constellation_azure_iam | ||
| curl --remote-name-all https://raw.githubusercontent.com/edgelesssys/constellation/main/hack/terraform/azure/iam/{main,output,variables}.tf |
There was a problem hiding this comment.
This should include the lockfile .terraform.lock.hcl. The azure terraform iam readme also misses this step.
Co-authored-by: Malte Poll <mp@edgeless.systems>
Co-authored-by: Malte Poll <mp@edgeless.systems>
Co-authored-by: Malte Poll <mp@edgeless.systems>
leongross
pushed a commit
that referenced
this pull request
Nov 17, 2022
* AB#2578 Azure IAM init * AB#2578 Fixed application owner privileges, added docs * Add all supported providers to TF lockfile * Using service principal for role assignment in cluster resource group Co-authored-by: Malte Poll <mp@edgeless.systems> * Rephrased header for Azure Co-authored-by: Malte Poll <mp@edgeless.systems> * Registry -> Registration typo Co-authored-by: Malte Poll <mp@edgeless.systems> * Download lockfile * File name casing Co-authored-by: Malte Poll <mp@edgeless.systems>
david-crypto
pushed a commit
that referenced
this pull request
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change(s)
Checklist