Add support for building code objects post-PEP570 #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
force-pushed
the
pep570
branch
2 times, most recently
from
a9d3aed
to
de3e9a4
Compare
|
Thanks 🎉 |
|
Genshi 0.7.2 doesn't include this fix. Would it be possible to get a new release? genshi benchmark was disable in performance project because it is not compatible with Python 3.8: FYI I proposed to add a new code.replace() method which should make genshi more future-proof once it will use it ;-) https://bugs.python.org/issue37032 |
|
This conversation already happens at #18 (comment) |
|
Genshi 0.7.3 with the PEP 570 fix included has been released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch makes genshi compatible with the Python 3.8 alpha, which changed the representation of code objects to support positional-only arguments.
Closes: #18