This repository has been archived by the owner on Apr 23, 2021. It is now read-only.
fix: App-service-configurable failing to start #440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lenny-intel, @jinlinGuan, @cloudxxx8 please review. |
lenny-goodell
suggested changes
Apr 27, 2020
Testing instructions |
app-service-configurable is failng to start due to changes in implementation and settings. There are currently 27 assertion failures related to ASC in the blackbox tests that are resolved by this patch. Signed-off-by: Bryon Nevis <bryon.nevis@intel.com>
lenny-goodell
approved these changes
Apr 27, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
app-service-configurable is failng to start due to changes
in implementation and settings. There are currently 27
assertion failures related to ASC in the blackbox tests.
This patch resolves some, but not all of these failures
Signed-off-by: Bryon Nevis bryon.nevis@intel.com