Registry Abstraction usage and added watching writeable section #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloudxxx8
requested changes
Feb 27, 2019
Signed-off-by: lenny-intel <leonard.goodell@intel.com>
lenny-goodell
force-pushed
the
AbstractRegistry
branch
from
151fc50
to
7182ec0
Compare
Signed-off-by: lenny-intel <leonard.goodell@intel.com>
cloudxxx8
approved these changes
Feb 27, 2019
|
@cloudxxx8 , @tonyespy do I need other approvals or can I merge? |
This was referenced Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issues #85 & #159.
Device services will now use the Registry when started with -r or -registry
The registry type to use is in Registry section of the configuration.toml , ex: Type="consul"
The new Writeable section has been added to the configuration with just LogLevel and Logging section adjusted.
Devices service will now listen for changes to the Writeable section