Accept config directory from ENV variable #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Trevor Conn <trevor_conn@dell.com>
Signed-off-by: Trevor Conn <trevor_conn@dell.com>
drasko
reviewed
Mar 25, 2018
pkg/config/config.go
Outdated
| contents, err := ioutil.ReadFile(path) | ||
| path := determinePath() | ||
| fileName := determineConfigFile(profile) | ||
| contents, err := ioutil.ReadFile(path + fileName) |
There was a problem hiding this comment.
I think it would be more self-documenting if we were not to force path ending with /, but rather have here something like: path + "/" + filename
There was a problem hiding this comment.
Good, this is something I wanted to get feedback on. I don't have a strong preference.
pkg/config/config.go
Outdated
| path = configDirectory | ||
| } | ||
|
|
||
| if path[len(path)-1:] != "/" { |
There was a problem hiding this comment.
Maybe no need to enforce finishing with /. As explained before.
Signed-off-by: Trevor Conn <trevor_conn@dell.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for this issue: #26