Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Services using registry are immediately unregistered with the registry #49

Closed
brandonforster opened this issue Feb 17, 2020 · 0 comments · Fixed by #51
Closed

Services using registry are immediately unregistered with the registry #49

brandonforster opened this issue Feb 17, 2020 · 0 comments · Fixed by #51
Assignees
@michaelestrin @lenny-goodell
Labels
3-high priority denoting release-blocking issues bug Something isn't working geneva

Comments

@brandonforster
Copy link

Because of the location of the defer statement on startup with registry, services that use the registry are immediately unregistered with the registry because the RunAndReturnWaitGroup function returns almost immediately after the defer statement.

This block of code needs to be refactored to rely on some other timing mechanism.
@brandonforster brandonforster added bug Something isn't working geneva labels Feb 17, 2020
@brandonforster brandonforster added the 3-high priority denoting release-blocking issues label Feb 17, 2020
michaelestrin added a commit to michaelestrin/go-mod-bootstrap that referenced this issue Feb 18, 2020
@michaelestrin
Services using registry are immediately unregistered with the registry
f8164db 
Fixes: edgexfoundry#49
Signed-off-by: Michael W. Estrin <me@michaelestrin.com>
@michaelestrin michaelestrin mentioned this issue Feb 18, 2020
Merged
13 tasks
michaelestrin added a commit that referenced this issue Feb 18, 2020
@michaelestrin
Services using registry are immediately unregistered with the registry (
b680645 
#51)

Fixes: #49
Signed-off-by: Michael W. Estrin <me@michaelestrin.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@michaelestrin michaelestrin

@lenny-goodell lenny-goodell

Labels
3-high priority denoting release-blocking issues bug Something isn't working geneva
Projects
None yet
Milestone
No milestone
3 participants
@michaelestrin @brandonforster @lenny-goodell