Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Deployment section to README #169

Merged
merged 1 commit into from
Jul 14, 2018
Merged

Added Deployment section to README #169

merged 1 commit into from
Jul 14, 2018

Conversation

sebastianseilund
Copy link
Contributor

  • Described the pitfalls of not using node_id properly.
  • Simplified Heroku config example to emphasize the important part.
  • Added warning about duplicate dyno environment variables in Heroku.
  • Added Kubernetes section.

@sebastianseilund
Added Deployment section to README
819bb54 
- Described the pitfalls of not using `node_id` properly.
- Simplified Heroku config example to emphasize the important part.
- Added warning about duplicate dyno environment variables in Heroku.
- Added Kubernetes section.
@sebastianseilund sebastianseilund mentioned this pull request Jul 13, 2018
Closed
@edgurgel edgurgel merged commit 2be8a74 into edgurgel:master Jul 14, 2018
@edgurgel
Copy link
Owner

That's awesome! Great explanation 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgurgel edgurgel edgurgel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastianseilund @edgurgel